Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2.4] Add support for missing Curl methods to the Curl client #39471

Open
wants to merge 5 commits into
base: 2.4-develop
Choose a base branch
from
Open

[2.4] Add support for missing Curl methods to the Curl client #39471

wants to merge 5 commits into from

Conversation

lbajsarowicz
Copy link
Contributor

Description (*)

Cherry-picked change from #39330 rated as "backwards-incompatible" by @engcom-Dash rejecting all the changes to Testing Framework, leaving just the new methods in the Curl class.

It makes me upset that after spending hours to get the previous PR in shape to merge, this bug fix was taken down instead of recommendation to fix imaginary "backwards incompatiblity", provided Maintainers can point what change became backwards-incompatible.

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes magento/magento2#<issue_number>

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

@m2-assistant M2 Assistant
Copy link

m2-assistant bot commented Dec 12, 2024

Hi @lbajsarowicz. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.
❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

@lbajsarowicz
Copy link
Contributor Author

@magento run all tests

@lbajsarowicz
Copy link
Contributor Author

@magento run all tests (after changing the method to pass payloads)

@magento-automated-testing Magento Automated Testing
Copy link

Failed to run the builds. Please try to re-run them later.

@bgorski
Copy link
Contributor

bgorski commented Dec 12, 2024

@magento run all tests

@lbajsarowicz
Copy link
Contributor Author

@magento run all tests

I simplified the delete method signature to make the method compatible to the Magento\TestFramework, which - according to @engcom-Dash (in #39330) has higher priority than Magento\Framework.

@Priyakshic Priyakshic added the Project: Community Picked PRs upvoted by the community label Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@engcom-Hotel engcom-Hotel engcom-Hotel requested changes

@bgorski bgorski bgorski requested changes

Assignees
No one assigned
Labels
Priority: P3 May be fixed according to the position in the backlog. Progress: needs update Project: Community Picked PRs upvoted by the community
Projects
Community Dashboard
Status: Changes Requested
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lbajsarowicz @bgorski @engcom-Hotel @Priyakshic @magento-ct-gh-projects-svc